"Are such intentions viewed as greedy?"
If by "good effect" you mean it's a virtuous behavior that produces good kamma fruit, than I find the following blameless:
"if I do action X, it will produce good effects in the future for me"
If a person understand such is the case, the above is simply an acknowledgement of the outcomes that are expected. And if one knows this, one shouldn't refuse doing
X afraid of greed. The entirety of the virtue training is based on this very knowledge: of what actions produce what results. We are encouraged to know and see how doing
Y is not for our good, and how doing
X is; and we are encouraged to do things for our well-fare and well-fare of others.
The greed case likely would be one where "good effects" means producing things that are blameful or not connected to virtue or spiritual life, and there is a desire for these things.
"it may make me look like a good person"
The above might also not be related to greed: say a person who is good, and is seeing as someone who is bad, because of some misunderstanding or something else. It's for their good to try to correct their views and be seeing as the good person they are.
I think a greedy case here would be one where the person is craving and collecting praises of him or herself.